fix(previewer): disable PDF.js streaming and range requests#811
Merged
kpsherva merged 1 commit intoJun 11, 2026
Merged
Conversation
zzacharo
reviewed
Jun 10, 2026
| PREVIEWER_PDF_JS_DOCUMENT_INIT_PARAMS = { | ||
| "disableStream": True, | ||
| "disableRange": True, | ||
| "disableAutoFetch": True, |
Contributor
There was a problem hiding this comment.
curiosity: what did the autofetch do?
Author
There was a problem hiding this comment.
disableAutoFetch stops PDF.js from downloading extra bits of the PDF in the background before you actually need them like when you scroll down to the second page of the pdf, autofetch would fetch bits for the second page while you're scrolling so I turned off all three (disableRange, disableStream, disableAutoFetch) so the preview loads the file in one go instead of several small requests to the same PDF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDF previews were triggering duplicate network requests for the same file (the network tab showed the PDF being loaded twice). This adds PREVIEWER_PDF_JS_DOCUMENT_INIT_PARAMS to disable PDF.js streaming, range requests, and auto-fetch, so each preview loads the document in one request instead of multiple partial fetches against the server.